[#83] Create 'AssetError' and refactor 'select_asset' function to return it - Githubissues

chshersh / tool-sync

🧰 Download pre-built binaries of all your favourite tools with a single command

https://crates.io/crates/tool-sync

Mozilla Public License 2.0

69 stars 16 forks source link

[#83] Create 'AssetError' and refactor 'select_asset' function to return it #97

Closed zixuan-x closed 1 year ago

zixuan-x commented 1 year ago

Resolves #83

Refactored ToolInfo.select_asset(&assets) to return a custom AssetError error instead of a string and added tests for the function.

The AssetError enum has two possible values:

NameUnknown: this is when AssetName does not know what the asset name is for a specific OS the user uses.
NotFound: this is when the AssetName is not in the Assets slice passed into the select_asset(&assets) method.

Implemented std::fmt::Display trait for AssetError and added tests for it.

Additional tasks

[x] Documentation for changes provided/changed
[x] Tests added