chshersh / zbg

✨ Zero Bullshit Git
Mozilla Public License 2.0
183 stars 11 forks source link

#10 Use pure function instead of calling 'basename' #34

Closed LeedsJohn closed 9 months ago

LeedsJohn commented 9 months ago

Hi, this PR responds to issue #10. By the recommendation of @anuragsoni, I switched the fetch_main_branch function to use Core.Filename.basename rather than calling the basename command.

In the issue, you suggested to move stripping via basename into a separate function and to write tests but I did not do this because I think the functions in Core can be trusted.

Let me know if there's any changes you would like me to make. Thanks!