search

cht8687 / react-hover

React hover --- make hover easy http://cht8687.github.io/react-hover/example/
MIT License
107 stars 25 forks source link

Not compatible with TypeScript #16

Closed ajshres closed 3 years ago

ajshres commented 6 years ago

I like your extension library but as per my research, type definition can not be created for your library. Could you please separate Trigger and Hover from ReactHover definition and export as separate entity?

could you please export as export { Trigger, Hover }; instead of Change This

or any other viable solution

cht8687 commented 6 years ago

@ddvkid @ttma1046 any insights for this?

cht8687 commented 6 years ago

@ajshres Sorry for the late reply. The benefit of wrap the lib into ReactHover is that it won't have conflicts with other libraries in the project. I am not really sure what other impacts it will bring if we export them separately. What's the reason that type definition failed here? could you supply any insights so that we can tackle this together? cheers.

Isaius commented 4 years ago

Still not compatible with TS?

cht8687 commented 4 years ago

https://github.com/cht8687/react-hover/blob/master/src/index.js#L2

Released in 2.0.0