Closed brucealder closed 5 years ago
arnoldsmyth
commented
6 years ago You can now set it to view an album. I have this set up and add the photos that I want displayed. However I only have 125 or so in there at he moment. Are you saying that if you have thousands of photos in there that it only shows a subset of them?
chtaylo2
commented
6 years ago @brucealder glad you like the app, thanks for the feedback. If you work at Google, maybe you can help drive the Photos team to improve their API abilities. ;-) Shared album support, +11,000 image pulling are the two short comings I commonly hear.
On your points: 1.) If no albums are selected for screensaver, it'll randomly pull 5 albums + timeline album. Each one is limited to first 1000 items. >1000 items requires an additional API call which I have plans to build in, but haven't yet. Once the Screensaver starts, it doesn't make additional API calls. This was mostly to respect load on the API, but seems many folks are wanting this.
2.) Are the Archived photos it's showing part of an albums? Archiving only applies to the "Google Timeline Album". This code should prevent archived images showing when pulling from the primary album. I'll have to test that out some more.
brucealder
commented
6 years ago Hey Chris, Great to hear from you...I've seriously looked for years for a screensaver like PhotoView and as we just replaced our Android Player with a Roku, I found it with PhotoView (originally I went to great lengths to side load APKs on the Android Player in an effort to get the functionality that PhotoView provides).
Per your points: 1a) On the number of albums, I need to pay closer attention to which albums it's pulling (never set one), but that it would be pulling from 5 different albums seems to match what I'm seeing. 1b) Should it really be pulling up to 6000 photos (1000 each from the timeline album and the 5 additional albums)? That's a great capability. If it's truly pulling 1000 items per album that seems like a lot more than I'm actually seeing...I would have guessed it was pulling maybe ~100...or even ~50, I'll need to pay closer attention. If you are able to make changes that enable it to pull more than 1000 photos that would be fantastic...thanks in advance for considering this. 2) You're right, the archiving was done in the Timeline album...AND the photos are part of a separate album. If you implement the logic to skip archived photos in the Timeline album then, to take full advantage of this, I'll ensure that the album with the archived photos is not selected as part of screensaver.
On the Google Photos group front, I can definitely pass along Feature Requests if you provide more details (assuming you haven't already submitted these to the team)...it sounds like you have two:
11,000 image pulling - this would be huge...especially when you extend the API call to pull more than 1000 photos. If you want to provide details I can pass them along.
Btw, the Photos team is hiring (one of my employees interviewed, but it wasn't a good match)...have you considered working at Google? Bruce
On Sat, Mar 31, 2018 at 12:52 PM, Chris Taylor notifications@github.com wrote:
@brucealder https://github.com/brucealder glad you like the app, thanks for the feedback. If you work at Google, maybe you can help drive the Photos team to improve their API abilities. ;-) Shared album support, +11,000 image pulling are the two short comings I commonly hear.
On your points: 1.) If no albums are selected for screensaver, it'll randomly pull 5 albums + timeline album. Each one is limited to first 1000 items. >1000 items requires an additional API call which I have plans to build in, but haven't yet. Once the Screensaver starts, it doesn't make additional API calls. This was mostly to respect load on the API, but seems many folks are wanting this.
2.) Are the Archived photos it's showing part of an albums? Archiving only applies to the "Google Timeline Album". This code https://github.com/chtaylo2/Roku-GooglePhotos/blob/master/components/Slideshow/SlideshowHelper.brs#L168-L170 should prevent archived images showing when pulling from the primary album. I'll have to test that out some more.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chtaylo2/Roku-GooglePhotos/issues/111#issuecomment-377718780, or mute the thread https://github.com/notifications/unsubscribe-auth/AXcbsxxe1NpBS-BUQuVeUdTMWvXImmwcks5tj95wgaJpZM4TCjmE .
brucealder
commented
6 years ago @arnold, Yes, you nailed it...I have thousands and it seems to pull ~50, or maybe ~100 from several albums. I haven't specified an album, though, so I'll play with that and see if it improves things. Per Chris' post, it should pull 1000 per album (I would have guessed 50 to 100), so I need to pay close attention and confirm this.
On Sat, Mar 31, 2018 at 11:34 AM, Arnold Smyth notifications@github.com wrote:
You can now set it to view an album. I have this set up and add the photos that I want displayed. However I only have 125 or so in there at he moment. Are you saying that if you have thousands of photos in there that it only shows a subset of them?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chtaylo2/Roku-GooglePhotos/issues/111#issuecomment-377713843, or mute the thread https://github.com/notifications/unsubscribe-auth/AXcbs_GnaKnSl8E_yWmXeNUqAnZb1OT0ks5tj8xTgaJpZM4TCjmE .
Eserim
commented
6 years ago For me, it still seems to be only pulling in a small section of recent photos from my main timeline of auto backed up images. I wasn't aware that you could set the screensaver component to use a specific Album. I'll take a look again.
Ah - I missed the setting for album to use on screensaver - a bit hidden! So it all makes sense. If nothing chosen, it uses the first 1000 of timeline photos for random selection.
johnsko
commented
6 years ago I've spent a bunch of time confirming that it pulls only first 1,000. The workaround--putting photos in separate albums (and then selecting those albums)--is cumbersome but works well. An unfortunate limitation but still absolutely the best of many screensavers/slideshows I've tried on Roku.
brucealder
commented
6 years ago @johnsko - agreed completely, this is by far the best screensaver I've seen anywhere...even outside Roku
@chtaylo2 - I've created 5 albums with ~1000 photos each and it's working perfectly...no problems whatsoever...thanks for the great product. If you add an additional API call and can get more than 1000 photos please let us know, would love to use that option. Random question, would it be technically feasible to include videos in the albums and have the screensaver actually play those as it works it's way through the many photos? Thanks again...
chtaylo2
commented
6 years ago @brucealder / @johnsko - Agreed, the 1,000 limitation is on the Google API side per album. I could look at adding additional calls where total album count > 1000, but it's not there today. It does do this when viewing albums in the app w/ the use of paging feature. Selecting Page 1 - Page 11.
EricB2301
commented
6 years ago @chtaylo2 Have you been able to look at adding additional calls where total album count > 1000? This would be a great benefit over the other aps available. Thanks!
caldude321
commented
6 years ago Just wanted to say that this is a great project and product. I love being able to add photos to my 'Screensaver' album and have them appear on the TV; I use the same album for digital photo frames and my phones screensaver. I love having them all in sync. My wife adds photos to the album too, but they're not displayed, would really like Shared album support, as others have mentioned. I understand that it may be hard; google photos screensaver on android doesn't even do it.
Thanks for the hard work.
BethTimken
commented
5 years ago Wonderful screensaver!
I can't find where to select the albums from which I want to have my images drawn. Would someone please direct me?
chtaylo2
commented
5 years ago @BethTimken --
To select a specific album for the screensaver: -- "Roku Home" > Settings > Screensaver > select [PhotoView for Google Photos] -- In the Custom Settings, select a linked account (if you have multiple)
Rob-in-la
commented
5 years ago If I try to select an album I get an error. It says "an error occurred in the handleGetAlbumSelection Code: 400 - the requested URL returned error: 400 bad request.
I'm running the built-in Roku on a Hisense TV. Any ideas?
mikelmartin
commented
5 years ago I am getting the 400 bad request error as well. I have been running the screen saver for months (love it btw) but it started not working, and then when I went into settings and tried to select an album I get the 400 error.
BethTimken
commented
5 years ago Wonderful screensaver but I am having exactly the same problem as mikelmartin. It's been about 2-4 days. I've deleted it and reinstalled it, with no improvement.
The Roku PhotoView no longer works at all, instead the standard Roku screensaver comes on.
Rob-in-la
commented
5 years ago It looks like it's a known issue that Chris is hopefully working on. (See https://github.com/chtaylo2 )
It appears to stem from Google making a change to their photos API. It's an amazing app and will hopefully be back online soon.
I absolutely love PhotoView and think it serves a huge need on the Screensaver option (when serving up random photos from Google Photos). The only problem is that it accesses only a very small subset of photos (50? 100?), when I have a couple thousand photos. In addition, it accesses archived photos as well, would be nice if it skipped these.
I work at Google and may join the Photos team just to make this happen...because I've yet to see ANY application that simply serves up thousands of random photos as part of a screensaver offering.
If you could fix these two issues it would be revolutionary (the first is by far the highest priority): 1) Make PhotoView randomly access ALL photos in Google Photos...not just a subset 2) Make PhotoView access only the non-archived photos (or make this an on/off option if you want to give the user the choice).
Thanks!! Bruce Alder