search

chtd / psycopg2cffi

Port to cffi with some speed improvements
Other
177 stars 43 forks source link

Enable hstore test case and fix psycopg2cffi._impl.xid.Xid base64 #37

Closed ratazzi closed 9 years ago

ratazzi commented 9 years ago

Enable hstore test case and fix psycopg2cffi._impl.xid.Xid base64 support for Python 3

lopuhin commented 9 years ago

Thank you for spotting hstore test failures - looks like I never run these tests, there are a lot of failures - https://travis-ci.org/chtd/psycopg2cffi/builds/60182117. I can merge to master the part that fixes Xid base64 support for Python 3, and then fix hstore failures on a separate branch and enable hstore tests after that (or if you feel like doing it, I will be glad to accept a patch).

ratazzi commented 9 years ago

About hstore unicode issue, I want to create a pull request later, because it is not best solution and maybe it will not be merged.

lopuhin commented 9 years ago

All tests passed https://travis-ci.org/chtd/psycopg2cffi/builds/60327953

lopuhin commented 9 years ago

Merged Xid fix, created #38 for fixing hstore tests. Thank you!