fix maximum recursion depth exceeded error

chtd / psycopg2cffi

Port to cffi with some speed improvements

Other

177 stars 43 forks source link

fix maximum recursion depth exceeded error #47

Closed vuamitom closed 7 years ago

vuamitom commented 8 years ago

For method lookup, error 'maximum recursion depth' occurs when

'code' parameter is unicode instead of str
_cache is not passed as argument to recursive calls.

lopuhin commented 8 years ago

I'm on holiday right now, and will be able to do a proper review only after 7th of August, so I just had a quick look - the patch looks good and useful, thank you! The only thing that would be nice to add is some tests, also I think that this might not work with python3 due to unicode being undefined (although I did not check).

lopuhin commented 7 years ago

Sorry that I didn't finish and merge the PR in time - this issue got fixed in #68