chtof / chocolatey-packages

Apache License 2.0
12 stars 36 forks source link

Detect it Easy out of date #29

Closed TheCakeIsNaOH closed 3 years ago

TheCakeIsNaOH commented 3 years ago

Detect it Easy is out of date. Current version is 3.00, chocolatey package version 2.05.

Seems like the author's site has not been updated, while the github releases have been.

chtof commented 3 years ago

Version 3.0.1 under review. Thanks for the information.

TheCakeIsNaOH commented 3 years ago
chtof commented 3 years ago

Corrected, Version 3.0.1 under review.

TheCakeIsNaOH commented 3 years ago

Upgrading from version 2.05, it creates leaves the old files around. It has the 2.05 files in die_win32_portable, and it has the 3.01 files in die_win64_portable.

Also, uninstalling 3.01 (after upgrading from 2.05) leaves the old start shortcut for Detect it Easy Lite.

TheCakeIsNaOH commented 3 years ago

Also, the die.exe shortcut does not work if --forcex86 is passed on an x64 system.

chtof commented 3 years ago

I have no idea how I can handle that (--forcex86). I have just asked to stand-by the review of this version while waiting your answer.

TheCakeIsNaOH commented 3 years ago

See the calibre package for how to check for --forcex86 https://github.com/chocolatey-community/chocolatey-coreteampackages/blob/master/automatic/calibre/tools/chocolateyInstall.ps1#L17

The pr #31 also takes care of the other two items

chtof commented 3 years ago
# Remove the folder from previous versions that were win32 only
if (Test-Path $win32Dir) { Remove-Item -Recurse -Path $win32Dir -ea 0 }

Perhaps for next version win64dir should be also removed to avoid to keep files from a previous 64bits version installed.

Corrected version has just been submitted, thanks a lot for your help! :-)

TheCakeIsNaOH commented 3 years ago

Perhaps for next version win64dir should be also removed to avoid to keep files from a previous 64bits version installed.

That is probably a good idea.

thanks a lot for your help! :-)

You are very welcome.