search

chu11 / freeipmi-mirror

Mirror of GNU FreeIPMI Git Repo - http://savannah.gnu.org/projects/freeipmi/. I maintain the upstream of FreeIPMI and can accept Github pull requests.
GNU General Public License v3.0
12 stars 16 forks source link

Warning about NUL #46

Closed rlpowell closed 3 years ago

rlpowell commented 3 years ago

The issues described herein was the cause of a multi-hour debugging session after thousands of consoles were locked into the wrong baud rate in a datacenter.

Happy to change the wording, but I feel like some kind of "this is not a theoretical problem" warning needs to be in there. :)

chu11 commented 3 years ago

Sorry you had to suffer that. I was completely unaware of the NUL byte issue with agetty. I'm not entirely sure why it was never seen on systems we needed it for, although I suspect our console logs are chatty enough that the serial keepalives were ultimately only sent in "high probability there's an issue" cases. And I suspect a lot of the machines we had issues with we no longer have too.

I'd like to change the wording, let me look into it and I'll post a PR for you to take a gander at.

chu11 commented 3 years ago

@rlpowell sorry for delay, got a cold and was out sick. How about this: https://github.com/chu11/freeipmi-mirror/tree/NUL

I didn't think pointers to "man ipmiconsole" was necessary, as you sort of have to read them anyways. Perhaps could put a "for more information see ipmiconsole/bmc-info/bmc-config/ipmipower/etc. manpage" in front of every section of the relative conf files.

Edit: and of course I gave you authorship on the commit, b/c you did discover it and write the majority of it.

rlpowell commented 3 years ago

The reason that I had the man page pointers is that it was not obvious to me which of the many related man pages would explain the details of these options (i.e. that it's "man ipmiconsole" that gives this information, and not "man libipmiconsole" or "man ipmiconsole.conf"). I don't think it's essential, though; if you want to roll with that version I'm fine with it.

chu11 commented 3 years ago

Thanks. I've committed the fix to master & stable branches and will be in the next release.