search

chuababyy / pe

0 stars 0 forks source link

Editm without actually changing anything does not lead to an error. #9

Open chuababyy opened 10 months ago

chuababyy commented 10 months ago

Screenshot 2023-11-17 at 4.43.00 PM.pngScreenshot 2023-11-17 at 4.43.00 PM

With reference to person 7,

Using this command: editm 7 /name Taylor Swift /email taylorswift@era.tour /tele @tswift

is not changing any of the current information of the person, however the result message does not reflect this.

After using the command, I get the message that the person was successfully editted:

Screenshot 2023-11-17 at 4.44.06 PM.pngScreenshot 2023-11-17 at 4.44.06 PM

nus-pe-script commented 10 months ago

Team's Response

This is a valid issue and the app should display a message saying that parameters changed are the same to inform users.

However, we believe that this is not a big issue and is not important enough to be implemented in 1.4, because it doesn't affect the user in any way even if the none of the parameters are changed.

We also believe that users will use the editm function when they spot that there is a field to be change, and not to purposefully test the function to see whether it displays a message saying that the parameters are not changed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]