search

chuaindia / chuaindia.github.io

This project is the desktop version portfolio project following Figma template. This project contains my own information. This is written in HTML and CSS. Linter checks are used to make it error free. This contains "hover" action as well as "animation" action.
4 stars 0 forks source link

Pull Request : Deployment of Desktop Version of Portfolio #1

Open chuaindia opened 2 years ago

chuaindia commented 2 years ago

Deployment activity is done so that everyone can access the website. The website link is https//chuaindia.github.io.

zhadier commented 2 years ago

-

chuaindia commented 2 years ago

I changed the README.md file following the review of Reviewers. I think now it is following the README.md template. Thanks...........

chuaindia commented 2 years ago

I am attaching a screenshot of the README.md file. https://user-images.githubusercontent.com/106825373/188633032-68199020-5f3f-4114-8c04-ca32e8af89c4.png

awais-amjed commented 2 years ago

@chuaindia I think it looks good now but I think it would be better if you can copy the Readme file from the Microverse Template and make changes in that file instead of making your own. Since that will keep the correct formatting and the icons and emojis used in it as well. This will make your Readme look much more Professional 🤗

awais-amjed commented 2 years ago

STATUS: APPROVED 🥳

Hi @chuaindia ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations on implementing the required changes! 🎉👏🥇✨

Highlights

gif

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

chuaindia commented 2 years ago

Thanks a lot.