chuan-yun / Molten

php probe for zipkin and opentracing
Apache License 2.0
792 stars 160 forks source link

PHP 7.4 support #137

Open remicollet opened 5 years ago

remicollet commented 5 years ago

Build fails for now

At least with new php_pcre_match_impl prototype

lijiefeng-lee commented 2 years ago

php74 不行hp_pcre_match_impl(cache, subject, strlen(subject), result, subpats, 0, 0, 0, 0 TSRMLS_CC); ^~~ In file included from /usr/src/php/ext/molten/molten_intercept.h:38, from /usr/src/php/ext/molten/molten_intercept.c:16: /usr/local/include/php/ext/pcre/php_pcre.h:45:70: note: expected 'zend_string ' {aka 'struct _zend_string '} but argument is of type 'char ' PHPAPI void php_pcre_match_impl(pcre_cache_entry pce, zend_string subject_str, zval return_value,


/usr/src/php/ext/molten/molten_intercept.c:338:45: warning: passing argument 3 of 'php_pcre_match_impl' makes pointer from integer without a cast [-Wint-conversion]
         php_pcre_match_impl(cache, subject, strlen(subject), result, subpats, 0, 0, 0, 0 TSRMLS_CC);
                                             ^~~~~~~~~~~~~~~
In file included from /usr/src/php/ext/molten/molten_intercept.h:38,
                 from /usr/src/php/ext/molten/molten_intercept.c:16:
/usr/local/include/php/ext/pcre/php_pcre.h:45:89: note: expected 'zval *' {aka 'struct _zval_struct *'} but argument is of type 'size_t' {aka 'long unsigned int'}
 PHPAPI void  php_pcre_match_impl(pcre_cache_entry *pce, zend_string *subject_str, zval *return_value,
                                                                                   ~~~~~~^~~~~~~~~~~~
/usr/src/php/ext/molten/molten_intercept.c:338:70: warning: passing argument 5 of 'php_pcre_match_impl' makes integer from pointer without a cast [-Wint-conversion]
         php_pcre_match_impl(cache, subject, strlen(subject), result, subpats, 0, 0, 0, 0 TSRMLS_CC);
                                                                      ^~~~~~~
In file included from /usr/src/php/ext/molten/molten_intercept.h:38,
                 from /usr/src/php/ext/molten/molten_intercept.c:16:
/usr/local/include/php/ext/pcre/php_pcre.h:46:21: note: expected 'int' but argument is of type 'zval *' {aka 'struct _zval_struct *'}
  zval *subpats, int global, int use_flags, zend_long flags, zend_off_t start_offset);
                 ~~~~^~~~~~
/usr/src/php/ext/molten/molten_intercept.c:338:9: error: too many arguments to function 'php_pcre_match_impl'
         php_pcre_match_impl(cache, subject, strlen(subject), result, subpats, 0, 0, 0, 0 TSRMLS_CC);