Upgrade to version 2 zipkin format?

chuan-yun / Molten

php probe for zipkin and opentracing

Apache License 2.0

793 stars 160 forks source link

Upgrade to version 2 zipkin format? #93

Closed codefromthecrypt closed 6 years ago

codefromthecrypt commented 6 years ago

It seems likely that we are having issues due to data format here: https://github.com/apache/incubator-skywalking/issues/1495#issuecomment-408727598

Can you consider moving to v2 format or using https://github.com/openzipkin/zipkin-php? It is easy for people to get this wrong.. many use v2 by default. Eventhough the server can read both formats, people get the endpoint wrong.

silkcutKs commented 6 years ago

@adriancole already support zipkin v2 format, user can set molten.span_format=zipkin_v2

silkcutKs commented 6 years ago

resolved