search

chuanhao01 / oes-rsfg

OES Report Sick Format Generator (OES-RSFG)
https://chuanhao01.github.io/oes-rsfg/
MIT License
0 stars 0 forks source link

Thoughts for improvement #3

Open chuanhao01 opened 1 year ago

chuanhao01 commented 1 year ago

I think as long as the forms do not overlap, I can split them up. That way, each format generator component can be separated into its own custom component

Of course the definition of the values props passed down will be handled by the parent component But I could also just use a React.Context for that Wow, I wonder if this is actually the use for React.Context

I.e. Persona Particular -> 1 tsx file Report Sick -> 1 tsx file (Output and link also in the tsx file) Outcome -> 1 tsx file

The page still has to thought of as 1 whole But atleast this way, you can have some level of abstraction.

chuanhao01 commented 1 year ago

ReportSick and OutCome TextArea can be abstracted into a common reportsick format And then outcome added on top

chuanhao01 commented 1 year ago

There is probably a better way to set ReportSickTypes

chuanhao01 commented 1 year ago

UpdateESSRadioGroup is also bad

chuanhao01 commented 1 year ago