search

chuanxshi / javascript-patterns

JavaScript Design Patterns
http://shichuan.github.io/javascript-patterns
9.39k stars 1.69k forks source link

Switch is antipattern!.. #62

Closed norlin closed 6 years ago

norlin commented 12 years ago

pls, tell me where I'm wrong

norlin commented 11 years ago

Ping. Guys, what about this request?

norlin commented 11 years ago

Ping... Anybody home?

say2joe commented 11 years ago

People go on vacation this time of year. Perhaps, if you wait another day or two, you may find the response you're seeking.

Joe Johnson 657-464-HTML

On Fri, Jul 19, 2013 at 8:22 AM, Alexey notifications@github.com wrote:

Ping... Anybody home?

— Reply to this email directly or view it on GitHubhttps://github.com/shichuan/javascript-patterns/pull/62#issuecomment-21256309 .

say2joe commented 11 years ago

Oh. You've been waiting over a month?

Joe Johnson 657-464-HTML

On Sat, Jul 20, 2013 at 3:48 PM, Joe Johnson say2joe@gmail.com wrote:

People go on vacation this time of year. Perhaps, if you wait another day or two, you may find the response you're seeking.

Joe Johnson 657-464-HTML

On Fri, Jul 19, 2013 at 8:22 AM, Alexey notifications@github.com wrote:

Ping... Anybody home?

— Reply to this email directly or view it on GitHubhttps://github.com/shichuan/javascript-patterns/pull/62#issuecomment-21256309 .

norlin commented 11 years ago

Look at pull request date – i'm waiting more than 10 months! :)

norlin commented 10 years ago

Ping... Someone?

norlin commented 7 years ago

So... Ping? :-)

p.s. anyway since switch performance was improved in modern browsers I think this pull request is not relevant anymore... While I still don't like switch in JS.

chuanxshi commented 6 years ago

@norlin @say2joe sorry guys for the looong waiting, merged!

norlin commented 6 years ago

Well... Thanks! Just I'm not sure this change is relevant anymore, I guess all modern JS engines have been updated :-)