chubbymaggie / synoptic

Automatically exported from code.google.com/p/synoptic
0 stars 0 forks source link

Display GWT parsing errors next to the problem inputs #149

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently, parsing errors are shown at the top of the interface (with giant 
italic red font). The log parsing errors highlight the problem line in the 
input. However, the other error types do not provide much information about 
which of the inputs led to the problem.

An improvement would be to:

1) Display the error message (in smaller, red font) next to the input with the 
problem.

2) Highlight the input type. For example, by creating a thin red div around the 
input field.

Original issue reported on code.google.com by bestchai on 13 Nov 2011 at 5:47

GoogleCodeExporter commented 9 years ago

Original comment by kevin.a....@gmail.com on 21 Dec 2011 at 3:12

GoogleCodeExporter commented 9 years ago
I highlighted the input type (i.e. created a thin red border). Solution in 
revision 3da261c6f0ab, please code review.

Original comment by kevin.a....@gmail.com on 27 Dec 2011 at 1:08

GoogleCodeExporter commented 9 years ago
Revision 3da261c6f0ab has a bug, where the red border does not disappear after 
a successful re-parse. To reproduce:
1. Select ShoppingCart example
2. Modify one of the log lines to not be parseable
3. Parse Log
4. Delete modified log line to make entire log parseable
5. Parse log
6. Go back to the Inputs tab and observe that the input log has a red border, 
even though the log was parsed OK.

Original comment by bestchai on 31 Dec 2011 at 3:54

GoogleCodeExporter commented 9 years ago
Bug fixed in revision 4512d11feeb9. Issue closed and merged into default with 
revision 725961986842 

Original comment by bestchai on 31 Dec 2011 at 5:22