search

chubbymaggie / synoptic

Automatically exported from code.google.com/p/synoptic
0 stars 0 forks source link

GWT Model Tab: Allow user to select multiple nodes. #160

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Only one node can be selected at a time (and its corresponding log lines 
viewed).

Original issue reported on code.google.com by a.w.davi...@gmail.com on 16 Nov 2011 at 2:10

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
By "select," I mean be able to activate nodes together to have access to the 
log lines responsible for their specific partition node in the graph.  

So far, one possible way to do this could be to create an array in the current 
graph_handler.js file that keeps track of nodes.  However, it might be easier 
to extend model code in the future by moving the graph code into GWT (this 
would be its own issue entirely, though).

There has to be some sort of visual cue to know that more than one node can be 
selected (something like a check box or a key combination (like shift+click) 
with tooltip) to inform the user how to do so.

This enhancement can be used for finding the relations between multiple nodes 
by selecting their specific log lines, making it possible to examine relations 
between the different partitions based on the data that this would extract from 
the graph.

Original comment by a.w.davi...@gmail.com on 16 Nov 2011 at 6:17

GoogleCodeExporter commented 9 years ago 
Multiple nodes can be selected (and log lines for single nodes can be checked). 
 As of yet, nothing outside of graphhandler.js tracks the selected nodes.

A method call can be added in the node's "toggleSelected" function (defined in 
graphhandler.js) to do this if necessary.

Requesting code review on revision 62e742a2eda0.

Original comment by a.w.davi...@gmail.com on 25 Dec 2011 at 5:47

GoogleCodeExporter commented 9 years ago 
There's a bug when "Manual refinement/coarsening" is checked on the Inputs 
panel. To re-produce:
1. Use the TwoPhaseCommit example
2. Under "Debugging options" select "Manual refinement/coarsening"
3. Parse Log
4. In the Model tab, shift-click a few notes
5. Click Refine to perform one step of refinement

In the resulting graph the node colors are not updated on click, and 
shift-click doesn't work.

I think the solution should be to reset node colors and node state to 
de-selected whenever the graph is updated -- either with a completely new 
model, or with a changing-graph (during one-step of refinement/coarsening).

Original comment by bestchai on 25 Dec 2011 at 2:24

GoogleCodeExporter commented 9 years ago 
Left code review comments on revision 589f9b312361 and revision 62e742a2eda0

Original comment by bestchai on 25 Dec 2011 at 2:42

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Disregard last request for code review.  I realized there was a much simpler 
solution.  Requesting code review on revision d96cc5d7a809

Original comment by a.w.davi...@gmail.com on 9 Jan 2012 at 11:04

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Looks good. Merged into default in revision 51128d7557e1

Original comment by bestchai on 10 Jan 2012 at 3:58