GWT Model Tab: Display set of paths as a list next to the model

[GoogleCodeExporter]

Title says it all, really.

Original issue reported on code.google.com by a.w.davi...@gmail.com on 16 Nov 2011 at 2:20

• Blocking: #163, #60, #205
• Blocked on: #161

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

As Ivan suggested, the list could be displayed as radio buttons which could 
then show the corresponding log lines and highlight the graph (as outlined in 
issue 163).

Original comment by a.w.davi...@gmail.com on 16 Nov 2011 at 2:25

[GoogleCodeExporter]

This description is insufficient. It should provide enough detail so that 
anyone working on the project could understand it and attempt to resolve it. If 
you do not make headway in this issue, then someone else will have to jump in 
to help you. However, this will not be possible unless they can understand the 
issue.

Here are some of the things you should have included:

1. Explain what are paths: paths are logged executions that are in the input 
log.

2. How a path might be displayed: a path can be displayed either by listing the 
set of events that make up the path, or by giving it a unique identifier/hash, 
or by naming the file that it comes from, or by naming the file and log line 
that corresponds to the first event in the path. 

3. Why should the paths be displayed / what is the context : we want to display 
the paths that pass through a set of nodes/partitions selected in the model. We 
want to do this to offer the user more introspection into what the model 
represents and how the log matches the model.

4. Why should the paths be made interactive : we want to support the use case 
in which the user selects a path and we show the user a path in the model that 
corresponds to the path. Therefore, the user must have the ability to indicate 
which path they want to be displayed in the model.

etc.

Please take care to author more verbose and meaningful issue descriptions in 
the future. And, please provide sufficient detail for the other issues that 
you've authored today -- they all seem to have the same problem.

Original comment by bestchai on 16 Nov 2011 at 4:56

[GoogleCodeExporter]

Original comment by a.w.davi...@gmail.com on 20 Jan 2012 at 10:29

• Changed state: Started

[GoogleCodeExporter]

I've added a class to deal with the log info (both log lines and showing the 
traces associated with the different paths).  I wasn't too sure how to display 
this information in a good way, but I thought it would be good for only one 
thing to be displayed at a time.  So, the new class handles toggling back and 
forth between showing log lines and showing info about paths.  There's also 
functionality for the user to manually toggle between what's being shown (right 
now it's being done by clicking on the rectangular label.  It's likely going to 
be temporary, though, as it isn't apparent at all to the user that you can 
click on the label).

All this is in revision 8a52a67fbd2b, by the way.

Original comment by a.w.davi...@gmail.com on 25 Jan 2012 at 10:07

[GoogleCodeExporter]

Original comment by a.w.davi...@gmail.com on 26 Jan 2012 at 5:50

[GoogleCodeExporter]

Solution in revision 09ada997f091.  Please review.

Original comment by a.w.davi...@gmail.com on 26 Jan 2012 at 8:04

[GoogleCodeExporter]

The code looks good. I added some minor comments to revision 3e242c56c0c8, 
mostly about the new class PathsThroughPartitionsTable.

There is one outstanding issue with the interface. When I'm in the viewing 
paths mode, I'm unable to click on a node that is already outlined in red to 
see its log lines. This functionality was implemented to solve Issue 202 by 
Kevin, but it should only work in the log lines mode. In paths mode, clicking 
on a node that has already been selected in log-lines mode _should_ re-request 
the log lines.

Please implement a fix for this and address the review comments.

Original comment by bestchai on 27 Jan 2012 at 10:00

[GoogleCodeExporter]

Code review has been addressed and the bug is fixed.  The current solution is 
in revision a75f2468e7b0.  Please review.

Original comment by a.w.davi...@gmail.com on 30 Jan 2012 at 5:39

[GoogleCodeExporter]

Merged into default in revision 62a13980e3ff

Original comment by bestchai on 30 Jan 2012 at 8:37

• Changed state: Fixed