search

chubbymaggie / synoptic

Automatically exported from code.google.com/p/synoptic
0 stars 0 forks source link

Move arrow start/end points to the side of the event type label #179

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, the invariants graphic draws lines between event types in different 
columns in a way that overlaps the event type labels. That is, the arrow might 
start/end on top of the source/destination label and thereby obscure the text 
below.

It would help if the arrow start/end points were simply shifted to the 
right/left of the label.

Original issue reported on code.google.com by bestchai on 29 Nov 2011 at 7:55

GoogleCodeExporter commented 9 years ago 
Taking ownership.

Original comment by T.101.JV on 4 Dec 2011 at 10:27

GoogleCodeExporter commented 9 years ago 
So I've got something sorta working in revision aa468fc2830f, but it's a giant 
hack.
I use a labelOffset value (InvariantsGraph 115) and inverted the src and dst 
coordinates for the graphicarrow constructor call from graphic invariant 
(GraphicInvariant 66).

Some input on how to hack the labelOffset value and arrow arguments would be 
appreciated.

Also I forgot to use your style settings so the code review looks really nasty. 
I can create a new changeset if you'd like, in any case i can easily fix it.

Original comment by T.101.JV on 5 Dec 2011 at 12:05

GoogleCodeExporter commented 9 years ago 
This is a fine solution. A few todos (I'm not using a code review because the 
formatting is messed up):
1. Fix the format in all places where you've changed.
2. Add comments to every place where labelOffset appears (e.g., where it is 
defined, and where it passed as an argument).

Side note:
I'll add this to the dev docs, but a difficulty with revision aa468fc2830f is 
that you modified the format of every line, as well as committed code changes. 
This messes up the google code diff view and makes it difficult for me to 
determine which lines you've changed, and which lines were simply reformatted. 
In the future, please make sure that your code either makes formatting changes, 
or makes code changes, but never both at the same time.

For reference, I used the following hg diff command line:
$ hg diff -w -r 88632981cb2e:aa468fc2830f

Original comment by bestchai on 5 Dec 2011 at 3:00

GoogleCodeExporter commented 9 years ago 
Solution in revision fc3574917b47 please review. Will fix .classpath with 
another commit.

Original comment by T.101.JV on 5 Dec 2011 at 7:53

GoogleCodeExporter commented 9 years ago 
Merged into default in revision 66ab56ad7fbf.

Original comment by bestchai on 5 Dec 2011 at 10:12