The model node whose log lines are displayed should be distinguished in some way

[GoogleCodeExporter]

In the model tab, if one clicks a model node, the log lines for that node will 
be listed on the left hand side. However, the node that was clicked is then not 
distinguished from other nodes. This is a problem because (1) there are 
possibly multiple nodes of the same event type, and (2) the mapping of a set of 
a log lines to a node requires one to understand the input regular expressions, 
which are not present on this screen, and is a difficult task.

A solution would be to distinguish the clicked node -- the node whose log lines 
are displayed -- with either a different background color, or a change to the 
node's border width/color, or something else. Whatever the method used to 
distinguish this node, the same feature(s) should be applied to the log lines 
listing table -- so that the user can visually associate the two.

Original issue reported on code.google.com by bestchai on 20 Jan 2012 at 6:26

[GoogleCodeExporter]

Taking ownership.

Original comment by kevin.a....@gmail.com on 21 Jan 2012 at 8:43

[GoogleCodeExporter]

Solution in revision f92c44bd7853, please review.

Original comment by kevin.a....@gmail.com on 23 Jan 2012 at 7:27

[GoogleCodeExporter]

Kevin, it seems that your implementation of Issue 196 broke the functionality 
Andrew implemented in Issue 160 -- shift click selects multiple nodes. Shift 
click works in revision e57f7536de7e, and stopped working in revision 
ebe6694573cc. You are both working on the same JS logic, so you both have to 
understand each other's code to integrate with it cleanly. Kevin, please 
implement a fix for 160 as part of this issue.

Original comment by bestchai on 23 Jan 2012 at 5:29

[GoogleCodeExporter]

Fixed this bug in revision a5e9d5ad66d9, please review.

Original comment by kevin.a....@gmail.com on 23 Jan 2012 at 8:28

[GoogleCodeExporter]

Two new bugs:

1. The "View Paths" button in the ModelTab is never activated. The function to 
activate it is ModelTab.toggleViewPathsButton. It's never activated because 
ModelTab.addSelectedNode and ModelTab.removeSelectedNode never seem to fire. 
Relevant code in ModelGraph.createGraph -- $wnd.addSelectedNode is set there, 
and this function should be called from JS logic.

2. When doing a shift-click, or just a single click, all nodes of the node type 
being clicked are highlighted and remain highlighted. Instead, just the node of 
that type should remain highlighted after the click.

Original comment by bestchai on 23 Jan 2012 at 8:50

• Changed state: Started

[GoogleCodeExporter]

Fixed these two bugs in revision 6654f736e8bb, please review.

Original comment by kevin.a....@gmail.com on 24 Jan 2012 at 7:35

[GoogleCodeExporter]

Ok, the visual behavior looks good, but there is another logic bug related to 
Issue 160 -- the "View Paths" button never returns any paths.

Here is a test:
1. Switch to revision e57f7536de7e (i.e., "hg up e57f7536de7e")
2. Run the 2PC example
3. Open a JavaScript console window (in Chrom this is under View -> Developer 
-> JavaScript Console)
4. Select the tx_prepare node in the model.
5. Click on "View Paths"
6. Observe that the console outputs 5 traces -- TRACE ID 0 through TRACE ID 4.

If you try the same test at the head of the Issue201 branch, then you'll notice 
an error at top of page that says that no paths were found through selected 
nodes.

Original comment by bestchai on 24 Jan 2012 at 8:19

[GoogleCodeExporter]

I wasn't able to reproduce this bug every single time. But I believe I have the 
correct fix though. Solution in revision a5061fc8e4c8, please review.

Original comment by kevin.a....@gmail.com on 25 Jan 2012 at 12:29

[GoogleCodeExporter]

That seems to have fixed it for me. Code looks good. Closing issue, merged 
branch into default with revision e41bb930c923.

Original comment by bestchai on 25 Jan 2012 at 2:01

• Changed state: Fixed