search

chubbymaggie / synoptic

Automatically exported from code.google.com/p/synoptic
0 stars 0 forks source link

Do not re-request log lines for a node that is already selected #202

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When a user selects a node to see its log lines, and the node is already 
selected (and its log lines are currently in view), then do not invoke an RPC, 
as this is unnecessary.

Relevant code at graphhandler.js:105

Original issue reported on code.google.com by bestchai on 20 Jan 2012 at 6:34

GoogleCodeExporter commented 9 years ago 
Taking ownership.

Original comment by kevin.a....@gmail.com on 21 Jan 2012 at 8:43

GoogleCodeExporter commented 9 years ago 
Solution in revision 1d04ab6b06d5, please review.

Original comment by kevin.a....@gmail.com on 25 Jan 2012 at 4:41

GoogleCodeExporter commented 9 years ago 
This works well, except that it is impossible to shift-click and de-select a 
node whose log lines are currently displayed. I think that this is a desirable 
feature. Without this, a user might decide to add nodes using shift-click, and 
then would need to reset all the collected state because the currently shown 
log lines are for a node that should not be part of the set (and cannot be 
removed, without selecting a node that should be part of the set).

A visual fix is to just show the thick red border for the node whose log lines 
are displayed. And not change the node's bgcolor to blue unless that node is 
part of the shift-click selected node set.

This is not entirely within the purview of this issue, but it's close enough. I 
think this is the only outstanding todo here.

(Also, be careful with updating your editor with the most recent file contents 
held by the file system. Your edits to graphhandler.js in revision 02e8f7b7c710 
exactly undid my edits to graphhandler.js in revision b101d532b9e3. These 
changes were minor, and are not a big deal, but this could be disastrous if the 
changes you were missing were important. I believe this is an editor issue 
because you branched in a way that  your local repo must have inherited my 
changes, but it seems that your editor did not. Or, you intentionally undid my 
changes, which I'm guessing is not the case :-)

Original comment by bestchai on 25 Jan 2012 at 4:59

GoogleCodeExporter commented 9 years ago 
I've refactored the final todo into a Issue 203. Closing issue, merged branch 
into default in revision 6620dd812365.

Original comment by bestchai on 25 Jan 2012 at 4:09