chubbymaggie / synoptic

Automatically exported from code.google.com/p/synoptic
0 stars 0 forks source link

Shift-click should de-select a node whose log lines are currently displayed #203

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When a node whose log lines are displayed is clicked, the resulting node is 
automatically added to the list of nodes through which the paths are going to 
be computed/shown. After this, it is impossible to shift-click and de-select a 
node whose log lines are currently displayed. I think that this is a desirable 
feature. Without this, a user might decide to add nodes using shift-click, and 
then would need to reset all the collected state because the currently shown 
log lines are for a node that should not be part of the set (and cannot be 
removed, without selecting a node that should be part of the set).

A visual fix is to show the thick red border for the node whose log lines are 
displayed. And not change the node's bgcolor to blue unless that node is part 
of the shift-click selected node set.

Original issue reported on code.google.com by bestchai on 25 Jan 2012 at 4:09

GoogleCodeExporter commented 9 years ago
Fixed as of revision a9650fe8d18c

Original comment by bestchai on 31 Jan 2012 at 7:54