Merge traces that have the same path when viewing paths through nodes in the model

[GoogleCodeExporter]

Multiple traces can map to the same path. In some extreme cases all the traces 
that pass through a set of nodes map to just one path. Attached is an example 
of this -- there is just a single path through invalid-coupon and reduce-price 
selected nodes for the ShoppingCart example, but there are 43 traces.

All the traces that map to the same path must be displayed as a group, so that 
the user is not overwhelmed with multiple traces that are in fact identical 
from the perspective of the model.

Original issue reported on code.google.com by bestchai on 6 Feb 2012 at 6:35

• Blocked on: #163

Attachments:

• multiple-traces-one-path.jpg

[GoogleCodeExporter]

Taking ownership

Original comment by a.w.davi...@gmail.com on 9 Feb 2012 at 10:31

• Changed state: Started

[GoogleCodeExporter]

I have the paths being shown individually (I think) at the current stage, 
however I'm not sure how to name the different paths.  I was thinking maybe 
something generic like "Path 1, 2, ..., n" might end up working for now, and 
then have the selected paths expand to show the set of traces (sorted).  And 
then, regarding Issue 205, these trace IDs could expand to further show the log 
lines.

Also, I'm thinking I might need to write some more (and better) test code for 
grabbing paths through selected partitions after this, because for larger logs 
like shopping cart (unrefined) I seem to be getting quite a few null pointer 
exceptions when highlighting the "check-out" and attempting to get the paths 
through said node.

Original comment by a.w.davi...@gmail.com on 11 Feb 2012 at 2:37

[GoogleCodeExporter]

For now, don't worry about the label text. We won't be able to fit much 
information in the label anyway, so we'll need to have some way of expanding 
the information.

And yes, testing the path logic is important, especially if you're seeing 
exceptions.

Original comment by bestchai on 11 Feb 2012 at 7:29

[GoogleCodeExporter]

Well, I originally thought I'd make the traces only show up when selecting a 
certain path to view, but then I decided to make them visible whenever by the 
user without having to view other paths (I figured it would be annoying to 
remove whatever traces one might be reading over when overlaying a separate 
path).  

This is currently in revision b0af5306caba.  If this looks good enough for now, 
then I'm fairly certain it's ready for code review.

Original comment by a.w.davi...@gmail.com on 13 Feb 2012 at 7:24

Attachments:

• scrn.jpg

[GoogleCodeExporter]

I've made some changes to ModelTab/JS code in default, can you merge this 
cleanly into the Issue214 branch? I'll review the code in the branch once you 
do this.

Original comment by bestchai on 13 Feb 2012 at 2:28

[GoogleCodeExporter]

Solution in revision 081c1349a89f.  Please review.

Original comment by a.w.davi...@gmail.com on 14 Feb 2012 at 12:33

[GoogleCodeExporter]

The interface works well, I think. I left a code review in revision 
b0af5306caba and in revision 185e435f5df4. Please address both of these.

Also, make sure to pull/update since I made some small changes.

Original comment by bestchai on 14 Feb 2012 at 2:49

[GoogleCodeExporter]

Solution in revision 9e6a915295da.  Please review.

Original comment by a.w.davi...@gmail.com on 15 Feb 2012 at 1:56

[GoogleCodeExporter]

I left a few more code review comments on revision 9e6a915295da.

Original comment by bestchai on 15 Feb 2012 at 6:00

[GoogleCodeExporter]

Solution in revision 42244898a698 (along with a few other bits of code cleanup 
for things I hadn't noticed were pointless previously).

As a side note, I've also enabled quite a number of compiler warnings in 
Eclipse thanks to the info in the link.

Original comment by a.w.davi...@gmail.com on 15 Feb 2012 at 7:05

[GoogleCodeExporter]

Fixed with revision 165dde6548a9

Original comment by bestchai on 15 Feb 2012 at 6:01

• Changed state: Fixed