chubbymaggie / synoptic

Automatically exported from code.google.com/p/synoptic
0 stars 0 forks source link

Make state processing logic conditional on having parsed state #281

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The current state processing code always runs, even when no state reg-exp was 
specified, or if no state was parsed from the log. Ideally, this code would 
only run when state was parsed. For example, the mergeStatesWithEventNodes() 
function linearly scans all of the parsed event instances, adding a parsing 
overhead. It's also clear that later state processing code would be similarly 
orthogonal to the current code.

This can be improved by adding a parsing flag that records whether or not state 
has been parsed and/or whether or not a state reg-exp was used. Then, this flag 
can be checked before calling mergeStatesWithEventNodes(), and in future code.

Original issue reported on code.google.com by bestchai on 22 Jan 2013 at 6:35

GoogleCodeExporter commented 9 years ago

Original comment by ssukkerd on 22 Feb 2013 at 10:35

GoogleCodeExporter commented 9 years ago
This branch was merged into Issue286. Solution in revision e9f27197af69, please 
review.

Original comment by ssukkerd on 25 Mar 2013 at 4:54

GoogleCodeExporter commented 9 years ago

Original comment by ssukkerd on 28 Mar 2013 at 9:38