chubbymaggie / synoptic

Automatically exported from code.google.com/p/synoptic
0 stars 0 forks source link

Stop using symlinks for EndToEndTests #354

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Synoptic uses symlinks from the traces/EndToEndTests/ directory to simplify 
testing. Unfortunately, hg does not properly create symlinks on windows (they 
appear as text files containing the linked-to location). This prevents the test 
suite from passing on Windows in a new clone.

We need to do a couple of things to resolve this:

1. Change Synoptic code to not depend on EndToEndTests.
2. Remove the EndToEndTests directory (and all of the contained symlinks) from 
the repo
3. Double check that removing this directory did not break other Synoptic or 
InvariMint tests.

Original issue reported on code.google.com by bestchai on 21 Jan 2014 at 8:39

GoogleCodeExporter commented 9 years ago

Original comment by osiscs...@gmail.com on 4 Feb 2014 at 6:27

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 32257295a4e3.

Original comment by osiscs...@gmail.com on 10 Feb 2014 at 2:34

GoogleCodeExporter commented 9 years ago
Please review

Original comment by osiscs...@gmail.com on 11 Feb 2014 at 5:39

GoogleCodeExporter commented 9 years ago
One more thing remaining to be done for this is to standardize behavior of the 
.dtrace file creation/deletion. These files are create on Windows under 
synoptic/ and remain there. On Linux/Mac these files are either not created or 
are created and then deleted.

Original comment by bestchai on 11 Feb 2014 at 6:01

GoogleCodeExporter commented 9 years ago
Standardizing the behavior of the .dtrace file creation/deletion has become its 
own separate issue now. Please see Issue 366 for more details

Original comment by osiscs...@gmail.com on 10 Mar 2014 at 2:32

GoogleCodeExporter commented 9 years ago
Solution in revision e31c4de85a43, please review

Original comment by osiscs...@gmail.com on 10 Mar 2014 at 2:34

GoogleCodeExporter commented 9 years ago

Original comment by bestchai on 11 Mar 2014 at 5:29