search

chubin / cheat.sheets

cheat.sh cheat sheets repository
MIT License
598 stars 209 forks source link

Add tests/max-length #129

Closed chubin closed 3 years ago

chubin commented 3 years ago

Add tests/max-length testing length of cheat sheets comment lines. Can be used interactively:

    $ tests/max-length
ghost commented 3 years ago

I think I'm missing something. Why are you sending yourself PRs?

chubin commented 3 years ago

Actually, the original idea was to open this PR and give it to your for review, but for that you need to be a collaborator in this project. I tried to add you as a collaborator, but you didn't accept the invitation, so I decided that there should be some reasons for that, so I merged the pull-request.

Also, another quite typical reason to open pull-requests is to make the automatic CI checks be automatically executed (it is irrelevant in this repository though, because we have no automatic CI checks currently).

ghost commented 3 years ago

Oooh! That makes sense. Thanks for explaining. Regarding the collaborator thing, see this link. Oh, and I can still submit reviews, despite not being a collaborator.

Selectshot_2020-11-12_16:24:46

Unless you mean something different than what the 'Review changes' button offers.

chubin commented 3 years ago

Oh, sorry, I missed this part. I am not sure that I understood what you meant about anonymity, because I didn’t think that it could be somehow affected with it. I think, the most important change is that you can make merges and be added as a reviewer to pull-requests

To say the truth I don’t understand why GitHub doesn’t allow to invite someone for a review if he is not a collaborator, but it is ok, one can use mentions instead