search

chuck-flowers / humble-lumpia

A script for managing installations of Glorious Eggroll's custom proton build
GNU General Public License v3.0
14 stars 2 forks source link

mention version that was installed when installing latest #14

Closed thibaultmol closed 3 years ago

thibaultmol commented 3 years ago

Hi, I'm wondering if it's possible to mention the version that is being installed when you do humble-lumpia install latest Because now it just says that it installed 'it'. But would be nice if you could see the actual version right there in the output of that command.

(thx for making this tool, it's very convenient)

chuck-flowers commented 3 years ago

I'm glad you find the tool useful.

I can add the feature as described relatively soon. I'll update this issue when I've merged it.

chuck-flowers commented 3 years ago

@thibaultmol I have added the feature as I understand it

Feel free to reopen this issue if you have any improvements in mind.

Also feel free to open other issues as they come to mind.

thibaultmol commented 3 years ago

Thx for the quick @chuck-flowers ! But it seems like it doesn't work (maybe because this version was already installed). image Also, maybe it's best that the first line it outputs when entering that command would Installing Proton-GE version x.x.x... and then it says Downloading ... Complete! Extracting ... Complete! followed by Proton-GE version x.x.x has been successfully installed

My argument for putting the version number as the first echo, is because some people might want to cancel the download if they notice it's not yet the right version (because they forgot to update first

NINNiT commented 3 years ago

@thibaultmol How are you installing humble-lumpia? If you are on Arch and using the AUR package, i just bumped the pkgrel - it should now definitely be flagged that an updated version exists.

The proton version information works fine for me:

❯ humble-lumpia install latest
Downloading... Complete!
Extracting... Complete!
Sucessfully installed '6.19-GE-2'

Edit: Maybe there is a case to just update the proton release file on every humble-lumpia run? Maybe with a diff to check if anything changed.

thibaultmol commented 3 years ago

Yeah, forgot it was a git package. It works correctly now

I guess if install latest is run, then it should check. if install x.x-GE-x is run, it should only check if it doesn't see the version number in it's release file.

chuck-flowers commented 3 years ago

That seems reasonable to me. I'll work on adding that soon.

chuck-flowers commented 2 years ago

@thibaultmol I pushed a new commit to master with the auto-refreshing behavior you described