search

chuckbergeron / etherplate

🔗 Use this to make your next Ethereum DApp w/ React (& Router), Redux, Bulma & OpenZeppelin ERC721
https://chuckbergeron.io
Other
78 stars 34 forks source link

Compilation warnings encountered #7

Closed dleonard00 closed 6 years ago

dleonard00 commented 6 years ago 
Compilation warnings encountered:

zeppelin-solidity/contracts/token/ERC721/ERC721Token.sol:38:3: Warning: Defining constructors as functions with the same name as the contract is deprecated. Use "constructor(...) { ... }" instead.
  function ERC721Token(string _name, string _symbol) public {
  ^ (Relevant source part starts here and spans across multiple lines).

I get this error when running truffle compile

Just wanted to document this, potentially I can create a PR for it soon.

chuckbergeron commented 6 years ago

Oh yeah, that's due to the version of OpenZeppelin Etherplate is using. I'm not sure if OpenZeppelin has updated their contracts with this, but it would simply require bumping the version in the package-lock.json file!