NetworkInterfaceRepository

[chucker]

Right now, we have:

• INetworkInterfacesService
• its concrete implementation MacNetworkInterfacesService, which in turn pulls in from:
  • NativeMethods, which is a mix of SystemConfiguration, IORegistry and BSD (oof)
  • SCNetworkInterface, which has more SystemConfiguration stuff (and has its own NativeMethods)
• NetworkInterfaceViewModel, which is yet another data source

Also, GetAvailableInterfaces reloads the list, but TryFindInterfaceByName does not. And GetAvailableInterfaces is (I believe) called twice, so we have two different instances of the list.

We should probably refactor this a lot. Something like:

• an enum NetworkInterfaceDataSource with values Bsd, IORegistry, Mono, and SystemConfiguration, and the [Flags] attribute
• a class NetworkInterfacesRepository, which is a read-only repository, with methods:
  • ReloadAll(NetworkInterfaceDataSource dataSources)
  • GetByBsdName(string bsdName)
  • ListAll()
  • QueryAll(Expression<Func<NetworkInterfaceViewModel, bool>> predicate), maybe? or do we just need QueryAllIsUp?
• each of the three data sources should be its own class with its own NativeMethods inner class

[chucker]

How do we define precedence, though?

Something like this, maybe?

1. if SystemConfiguration tells us an interface is up, believe it
2. otherwise, check if .NET (or BSD?) has assigned it a unicast IP address

[chucker]

This introduces a slight inconsistency: Bluetooth PAN shows up (and does not in NU).

[chucker]

• [x] IORegistryDataSource is still missing
• [x] Ping tab needs a new way to get the selected interface according to preferences
• [x] Throw out existing code

Anything else?