Master and Worker ignition files to singular + Check if ISO exists instead of download it each time

chuckersjp / coreos-iso-maker

Create a bunch of coreos ISOs for OCP 4.x installs when you need to set static IPs

Apache License 2.0

58 stars 51 forks source link

Master and Worker ignition files to singular + Check if ISO exists instead of download it each time #11

Closed lmulder closed 4 years ago

lmulder commented 4 years ago

With masters and workers as group in sample inventory.yml file, grub.cfg ends up with masters.ign and worker*s.ign url. This is not synced with openshift-install generated ignition files that come in singular.

ISO download each time playbook is called is rather annoying, so second proposition checks is file is already present and validates against provided checksum.

chuckersjp commented 4 years ago

Nice change. The re-download kind of annoyed me during testing but I never got around to fixing it.

I do have one request, though:

Can you remove the iso_checksum change?

Reason: Your change has the correct checksum. However, the current one now defaults to 4.5.2 (latest) and this is for 4.4.3 so it is sort of a regression.

With that part removed, I will happily merge this.

lmulder commented 4 years ago

Hello,

Just reverted all.yml file.