Added liveiso and Delete image url. - Githubissues

chuckersjp / coreos-iso-maker

Create a bunch of coreos ISOs for OCP 4.x installs when you need to set static IPs

Apache License 2.0

58 stars 51 forks source link

Added liveiso and Delete image url. #13

Closed lukyky414 closed 3 years ago

lukyky414 commented 3 years ago

As described in the issue: https://github.com/chuckersjp/coreos-iso-maker/issues/12

OpenShift v4.6 now use liveiso. That mean:

Grub.cfg and isolinux.cfg need a coreos.liveiso parameter, with the app id given in the iso.
There is no need to give image url

This merge change the app id of the generated iso.

Changed 'RHCOS-x86_64' and 'RHCOS-ppc64le' to 'RHCOS-CustomIso'.
Changed coreos.liveiso in all grub.cfg & isolinux.cfg to 'RHCOS-CustomIso'
Deleted image url in all grub.cfg & isolinux.cfg (+ in the playbook-multi)

chuckersjp commented 3 years ago

Looks good to me. I am trusting that this cleans up the issues. Thanks!