chucknorris / roundhouse

RoundhousE is a Database Migration Utility for .NET using sql files and versioning based on source control
http://projectroundhouse.org
917 stars 249 forks source link

Roundhouse Versioning process - not so helpful #246

Open MuruganMani opened 8 years ago

MuruganMani commented 8 years ago

The RoundhousE.version table doesn't have a column to specify whether the run is successful or not. Also it logs the version at the start of run and we have no clue whether the run is success or failed. This is very much required, and will be helpful if done.

image

ferventcoder commented 8 years ago

Perhaps you should be using the /transaction switch.

ferventcoder commented 8 years ago

You do have a good point. Perhaps this should have a column to know if it was successful.

kitroed commented 8 years ago

Is there any reason the ScriptsRunErrors table doesn't have a version_id? I thought this would be pretty straightforward to check for the presence of error records for a given migration attempt by joining.

Add my vote for some form of success flag on the Version table. Thanks!

ferventcoder commented 8 years ago

:+1:

kitroed commented 8 years ago

I want to amend my previous comment: I now understand why there's no reference from the ScriptsRunErrors table to the Version table: RoundhousE records errors, even when no Version record is written---this makes using the /transaction switch even more appealing.

However, when using rh without the /transaction switch (e.g. in a local development scenario), it would be nice to know if the run was successful when looking at the Version table data.