chucknorris / warmup

WarmuP - a simple templater / token replacement tool
44 stars 24 forks source link

Tfssupport #17

Closed dapngn closed 10 years ago

dapngn commented 11 years ago

This will add TFS support to warmup.

The regular warmup flow takes care of the rest.

ferventcoder commented 11 years ago

Thanks - we will take a look and evaluate this over the next month or two.

dapngn commented 10 years ago

Feel free to close this request. It would be a better fit in a plug-in architecture, rather than in the core code. There is a dependency on a couple of TFS libs, which come installed in VS2012, but are not available prior to that. Also, TFS is just not as flexible as the other SCM options, so that leads to some weird workarounds. Basically you can't just call the tool from within an existing workspace, because TFS doesn't support nested workspaces (that I am aware of), which leads to project generation, followed by moving it into the destination workspace. It was cool to get it working with TFS, but in the end, leaving it as a fork is fine.

ferventcoder commented 10 years ago

@RussMartinez That's fine. Keep in mind that this was still on the list to evaluate. If you were closing the PR just due to the above, then we are fine with that. If it was also because we are slow to evaluate, I'd urge you to keep it open. We will eventually get to it.

dapngn commented 10 years ago

@ferventcoder no worries. I have been mulling over a better implementation, testing, etc...