search

chucknorris / warmup

WarmuP - a simple templater / token replacement tool
44 stars 24 forks source link

Bug: Warmup converts .sln to ASCII file encoding #6

Closed Gaikotsu2 closed 12 years ago

Gaikotsu2 commented 12 years ago

The Visual Studio Version Selector used by Visual Studio 2010 to determine which version of VS to use to open a given .sln file is picky about the file encoding used on the .sln file. Point of fact, it won't actually open the file unless it's encoded using UTF8. Currently warmup is converting every file to ASCII when it does the token replacement.

Please change it to keep the encoding intact when doing the token replacement.

ferventcoder commented 12 years ago

Yeah - you check the issues? This is fixed in 0.6.0, which was just released about 30 minutes ago.

ferventcoder commented 12 years ago

chocolatey update warmup

http://chocolatey.org/packages/warmup

drusellers commented 12 years ago

what commit fixed this?

ferventcoder commented 12 years ago

https://github.com/chucknorris/warmup/pull/2

ferventcoder commented 12 years ago

And it converts everything to UTF8 which breaks other things... :(

ferventcoder commented 12 years ago

https://github.com/chucknorris/warmup/issues/7

drusellers commented 12 years ago

closed with issue #2

ferventcoder commented 12 years ago

Thanks for the cleanup comment Dru.

drusellers commented 12 years ago

its all good. I am only just now getting better at github issue management. Thanks to my crew at work. getting pretty good. ;)

ferventcoder commented 12 years ago

You using a neaters tool by one Ryan Rauh?

drusellers commented 12 years ago

that + just developing good habits