search

chucknorris / warmup

WarmuP - a simple templater / token replacement tool
44 stars 24 forks source link

Fixed Encoding Bug...Added GitHub downloader, which downloads a zip ball from git hub (doesn't require git to be installed) #9

Closed amirrajan closed 12 years ago

amirrajan commented 12 years ago

I added a GitHub downloader that explicitly forms a source url for github repos. This approach doesn't require git to be installed which will lower the barrier to entry for devs who...well...don't have git installed. I'm hosting a WarmuP template on GitHub and want to make it as easy as possible for a dev to WarmuP my template (don't want to force them to install git).

usage: warmup http://github.com/amirrajan/loam FoobarWebsite

I use an open source library called DotNetZip to unzip the source from github (MS-PL license): http://dotnetzip.codeplex.com/

localdeploy.bat helped me with testing locally....thought it would be good to have around

amirrajan commented 12 years ago

Apparently I'm really bad at pull requests....I accidentally merged these two features into the same request. The comments below are related to the "token replacement working while retaining BOM/Preamble" commit. I fixed the encoding issue...not sure if it needs to be this involved, but I couldn't find a reliable way to detect the BOM and at the same time do string manipulation....so I had to resort to bit shifting. I'm adding comments to all the pieces that had to change. This part warranted some testing...so I went ahead and added a test project and incorporated running the tests into build.bat.

amirrajan commented 12 years ago

If you need to me to split up the pull requests (again). Let me know and I'll redo them. The GitHub downloader changes are fairly small compared to the encoding bug.

ferventcoder commented 12 years ago

Awesome thanks! I have just a couple notes. The automated build already creates the gem, so you don't need the local deploy. The other is more an observation. In this case I don't mind the introduction of something big like a testing framework, but usually I like to have a discussion up front beforehand to be sure it aligns with the goals of the project.

drusellers commented 12 years ago

I am not sure if we will keep the NSpec or not. since that's not what Rob or I use, but the tests are much appreciated. :) Ideally the zip lib would be merged, I have no problem with it. I have used it in other projects myself.

drusellers commented 12 years ago

otherwise, everything looks good.

amirrajan commented 12 years ago

I have no problem creating NUnit tests instead of the NSpec tests if you're not comfortable with it...NSpec has a special place in my heart though :-D...if you guys are willing, I'm more than happy to discuss some of the benefits NSpec brings to the table over Skype.

But again, no big deal if you want NUnit instead, just let me know and I'll convert the tests over.

I'm in the Dallas, Texas (Central Time Zone) and am available during lunch or after 5.

amirrajan commented 12 years ago

here is the NSpec website: http://nspec.org

and a podcast with Scott Hanselman on it: http://hanselminutes.com/294/understanding-bdd-and-nspec-with-matt-florence-and-amir-rajan

amirrajan commented 12 years ago

Would next Wednesday work for you guys?

ferventcoder commented 12 years ago

Wednesday is out for me.

amirrajan commented 12 years ago

I'll make time whenever. Just let me know when you guys are available. I can also create another pull request that uses NUnit if you prefer. Really enjoying warmup's awesomeness, it's made my code katas in C# start up very fast.

On Fri, Feb 10, 2012 at 12:47 PM, Rob Reynolds reply@reply.github.com wrote:

Wednesday is out for me.

Reply to this email directly or view it on GitHub: https://github.com/chucknorris/warmup/pull/9#issuecomment-3912030

amirrajan commented 12 years ago

Just wanted to let you guys know that I'll be presenting at Dallas Days of .Net (http://www.dallasdayofdotnet.com/) and will talk about warmup along with other tools that help increase developer productivity :-). It's a decent sized conference (I believe Scott Hanselman is flying down from Seattle to also present). Thanks again for this gem :-).

drusellers commented 12 years ago

done

On Wed, Feb 15, 2012 at 10:03 PM, Amir Rajan < reply@reply.github.com

wrote:

Just wanted to let you guys know that I'll be presenting at Dallas Days of .Net (http://www.dallasdayofdotnet.com/) and will talk about warmup along with other tools that help increase developer productivity :-). It's a decent sized conference (I believe Scott Hanselman is flying down from Seattle to also present). Thanks again for this gem :-).

Reply to this email directly or view it on GitHub: https://github.com/chucknorris/warmup/pull/9#issuecomment-3994705

amirrajan commented 12 years ago

woo hoo!

ferventcoder commented 12 years ago

Look at you go Dru Sellers... ;)