search

chuckremes / ffi-rzmq

FFI bindings for ZeroMQ so the library can be used under JRuby and other FFI-compliant ruby runtimes
242 stars 62 forks source link

Add ZeroMQ 4 constants #101

Closed jasonroelofs closed 10 years ago

jasonroelofs commented 10 years ago

Doing this as a PR to see if I've followed how you'd like this done Chuck. This adds all the new constants in ZeroMQ 4. Currently requires zeromq4 built with libsodium (which you can build via homebrew through my PR https://github.com/mxcl/homebrew/pull/23180).

chuckremes commented 10 years ago

I'm going to reject this one since the constants and other items (libc.rb, libzmq.rb) were moved to the ffi-rzmq-core gem. This is part of an effort to separate out all of the FFI-specific things to its own gem. The separate gem will also make supporting multiple versions simpler (I hope).

jasonroelofs commented 10 years ago

@chuckremes Sorry about that, maybe I mis-read our emails. I was under the assumption we wanted to make this gem 4.x compatible before focusing on the ffi-rzmq-core gem? Either way I'll refocus my efforts on the new gem.

chuckremes commented 10 years ago

I was probably unclear. The last release of the gem (1.0.3?) supports libzmq 2.x through 3.2.x. The security API for libzmq is substantial enough that we should move to a 2.x release number. I had the ffi-rzmq-core stuff 90% done so I just completed that and pushed it today.

I'm happy to collaborate on a solid ffi-rzmq 2.0.0 release in the coming weeks. Let me know what you think.

On Nov 14, 2013, at 11:37 AM, Jason Roelofs notifications@github.com wrote:

@chuckremes Sorry about that, maybe I mis-read our emails. I was under the assumption we wanted to make this gem 4.x compatible before focusing on the ffi-rzmq-core gem? Either way I'll refocus my efforts on the new gem.

— Reply to this email directly or view it on GitHub.