search

chuigda / Project-705

中国式家长 - 山寨版
7 stars 1 forks source link

Upgrade to node 18 #45

Closed Shimogawa closed 1 year ago

Shimogawa commented 1 year ago

Node 16 EOL in 10 mo.

Upgrade to node 18

chuigda commented 1 year ago

Approved. I'll take a look @this afternoon.

chuigda commented 1 year ago

I've added a new workflow to build and test our project with node 18, and it passes. I think we can keep everything else as-is, and developers may migrate to node 18 at their own will, gradually.

@Shimogawa We may close this issue as accomplished, or keep it open as some prompt.

CousinZe commented 1 year ago

I think another workflow for frontend needs to be added.

Shimogawa commented 1 year ago

Should this be changed?

   "devDependencies": {
     "@types/express": "^4.17.13",
-    "@types/node": "^16",
+    "@types/node": "^18",
     "@types/uuid": "^8.3.4",
chuigda commented 1 year ago

Should this be changed?

   "devDependencies": {
     "@types/express": "^4.17.13",
-    "@types/node": "^16",
+    "@types/node": "^18",
     "@types/uuid": "^8.3.4",

Since these are just type definitions, and these definitions from node16 seems to work somehow with node 18, I think there's no need of changing it until we all switch to node 18.