search

chulkilee / ex_force

A Salesforce REST API wrapper for Elixir
https://hex.pm/packages/ex_force
MIT License
38 stars 27 forks source link

added support for multiple results in #get_sobject_by_relationship #36

Closed dirksierd closed 4 years ago

dirksierd commented 4 years ago

This would be my first open source-contribution, please let me know if something could be done better!

The pull-request simply adds support for multiple results in #get_sobject_by_relationship

With best regards

sourcelevel-bot[bot] commented 4 years ago

Hello, @dirksierd! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0a992897d241443682060fdbfa42fa1d8961500d on dirksierd:master into 99426cfc5b7e47a97c4976804b423444cb7b1f88 on chulkilee:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2455dc7426ed86a175c7e097c2b508852ca938e9 on dirksierd:master into 99426cfc5b7e47a97c4976804b423444cb7b1f88 on chulkilee:master.

chulkilee commented 4 years ago

Thanks! Looks good to me (will leave a few review comments)

Nitpick: Elixir doesn't use # to refer a function. get_sobject_by_relationship/5

For the record: https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/dome_relationship_traversal.htm

You can traverse relationships with multiple records, and get a response that contains the set of records. For relationships that resolve to multiple records, only GET methods are supported.

chulkilee commented 4 years ago

Merged and then squashed - thanks a lot!