chulkilee / ex_force

A Salesforce REST API wrapper for Elixir
https://hex.pm/packages/ex_force
MIT License
38 stars 27 forks source link

Please Include password+token in password field example. #37

Closed GenericJam closed 4 years ago

GenericJam commented 4 years ago

Thank you so much for this library.

Could you please include in your usage documentation that password needs to be password+token?

I was struggling with trying to get the library working for hours when I finally stumbled on this - https://developer.salesforce.com/forums/?id=906F000000099liIAA - combined with some other same JS code where I realized I needed cat password+token.

chulkilee commented 4 years ago

Good catch! Thanks for the report.

The linked salesforce doc actually mentions that btw.

You must append the user’s security token to their password A security token is an automatically-generated key from Salesforce. For example, if a user's password is mypassword, and their security token is XXXXXXXXXX, then the value provided for this parmeter must be mypasswordXXXXXXXXXX. For more information on security tokens see “Reset Your Security Token” in the online help.

I believe security token is not needed when when the requesting ip address is trusted: see Reset Your Security Token

When you access Salesforce from an IP address that’s outside your company’s trusted IP range using a desktop client or the API, you need a security token to log in

GenericJam commented 4 years ago

Hi Chulkilee,

Thanks for addressing that quickly. One more thing - it would be helpful if you included a link in your github readme to the hex documentation page. Otherwise, people have to independently find them through Google, etc.

All the best, Kevin

On Wed, 11 Dec 2019 at 18:01, Chulki Lee notifications@github.com wrote:

Closed #37 https://github.com/chulkilee/ex_force/issues/37 via #38 https://github.com/chulkilee/ex_force/pull/38.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chulkilee/ex_force/issues/37?email_source=notifications&email_token=ABMJYKIUO7FJY5HTJQZCQUTQYEME7A5CNFSM4JZRFHY2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVNPACOY#event-2875064635, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMJYKKSTNCVOOM62HNWVWDQYEME7ANCNFSM4JZRFHYQ .

chulkilee commented 4 years ago

Thanks for addressing that quickly. One more thing - it would be helpful if you included a link in your github readme to the hex documentation page. Otherwise, people have to independently find them through Google, etc.

Done at 467de59c53130eb9c3703ab8ea2282e0b1884b4c - the hexdoc will be updated at the next release. Thanks for the suggestion!