Handle failure when streaming

chulkilee / ex_force

A Salesforce REST API wrapper for Elixir

https://hex.pm/packages/ex_force

MIT License

38 stars 28 forks source link

Handle failure when streaming #50

Closed chulkilee closed 3 years ago

chulkilee commented 3 years ago

Fixes #48

[x] Use real error messages
[x] Fix credo warnings ;)

coveralls commented 3 years ago

Coverage remained the same at 100.0% when pulling 9825e745ae233f947beb02ec490919bb81f88f42 on handle-stream-fail into 49b26022940a504a9146ec4ce9a5b5493c7247fc on main.

sourcelevel-bot[bot] commented 3 years ago

SourceLevel has finished reviewing this Pull Request and has found:

1 possible new issue (including those that may have been commented here).

See more details about this review.

suranyami commented 3 years ago

So, I'm guessing, I should close #48 ?

suranyami commented 3 years ago

@chulkilee So, did this not get merged into main in the end? Why?

chulkilee commented 3 years ago

Wait, I thought I merged it and pushed to main 🤦 let me fix that