chundiliu / pyv8

Automatically exported from code.google.com/p/pyv8
0 stars 0 forks source link

no win 64 support #126

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What's involved in getting this working on win64?

I need to compile this for windows 64 bit 2.6 python.

I know enough C++ to have a play (read: to be dangerous) 

If you could give me a rough outline of what needs to be one I'll have a go.

Original issue reported on code.google.com by ndudfi...@gmail.com on 27 Jun 2012 at 2:11

GoogleCodeExporter commented 8 years ago
So I managed to build a win 64 build

It passes all tests. 

More warnings to add into the warning pie of course :)

Original comment by ndudfi...@gmail.com on 27 Jun 2012 at 3:43

GoogleCodeExporter commented 8 years ago
Great, could you submit a patch? thanks

Original comment by flier...@gmail.com on 29 Jun 2012 at 6:07

GoogleCodeExporter commented 8 years ago
Thanks for your patch, I have merged your patch at SVN r447, and I will update 
a wiki page soon

Original comment by flier...@gmail.com on 23 Sep 2012 at 1:01

GoogleCodeExporter commented 8 years ago
Dunno if the thanks was sarcasm or not :) I did send you a gist at one point?

Original comment by ndudfi...@gmail.com on 23 Sep 2012 at 2:18

GoogleCodeExporter commented 8 years ago
Yes, but I'm sorry about it because I'm almost forgot your contribution, just 
find it in the mail history and merge it :) 

The most cost is to install a Win7 x64 VM with VS2012 to verify the patch :P

Original comment by flier...@gmail.com on 23 Sep 2012 at 3:08

GoogleCodeExporter commented 8 years ago
No need for sorry :) Not sure I understand you but peace :)

Original comment by ndudfi...@gmail.com on 23 Sep 2012 at 3:11