chundongwang / superputty

Automatically exported from code.google.com/p/superputty
MIT License
0 stars 0 forks source link

Open Session dialog does not handle keys correctly #437

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open the Open Session dialog (<CTRL-O>)
2. Type in the first letters of the session you want to open
3a. If the first entry is the required session, pressing enter should open the 
session

3b. Browsing through the list if a filter is active by pressing the up and down 
keys

What is the expected output? What do you see instead?
3a. The session should open but in stead, a beep sounds and nothing happens

3b. The selector should move up and down the list but it looks like the second 
keystroke is ignored.

What version of the product are you using? On what operating system?
1.4.0.5 on Windows 7 32bit

Please provide any additional information below.

Original issue reported on code.google.com by dajo...@gmail.com on 24 Jun 2014 at 6:06

GoogleCodeExporter commented 9 years ago
I noticed too late that this issue is closely related to issue #421

Original comment by dajo...@gmail.com on 24 Jun 2014 at 6:09

GoogleCodeExporter commented 9 years ago
All you need to do (assuming you have Visual Studio) is change the following 
code in QuickSelector.cs

        private void textBoxData_KeyDown(object sender, KeyEventArgs e)
        {
            switch (e.KeyCode)
            {
                case Keys.Enter:
                    if (this.DataView.Count > 0) // Changed from == 1 to > 0 so as long as there's 1 or more, it'll select the first in the list which is usually the highlighted on.
                    {
                        this.DoSelectItem();
                    }
                    break;

Seems like the maintainers are taking a break from coding.

Original comment by djtrem...@gmail.com on 10 Jul 2014 at 10:52

GoogleCodeExporter commented 9 years ago
All you need to do (assuming you have Visual Studio) is change the following 
code in QuickSelector.cs

        private void textBoxData_KeyDown(object sender, KeyEventArgs e)
        {
            switch (e.KeyCode)
            {
                case Keys.Enter:
                    if (this.DataView.Count > 0) // Changed from == 1 to > 0 so as long as there's 1 or more, it'll select the first in the list which is usually the highlighted on.
                    {
                        this.DoSelectItem();
                    }
                    break;

Seems like the maintainers are taking a break from coding.

Original comment by djtrem...@gmail.com on 10 Jul 2014 at 10:52