Currently the Plugin does not check if the executable is the right one.
oidnDenoise.exe - Is correct and works.
oidnBenchmark.exe - Is invalid and only throws an Error: invalid argument in the debug console. Also locks up the Renderer.
oidnTest.exe - Is invalid and nothing happens.
DiskInfo64.exe - Is invalid and nothing happens.
Owing to how Chunky responded to oidnBenchmark.exe and Error: invalid argument I would recommend that we actually validate if the provided executable is the right one. Running oidnDenoise.exe or oidnDenoise.exe -h would show a list of valid command-line options.
Currently the Plugin does not check if the executable is the right one.
oidnDenoise.exe - Is correct and works. oidnBenchmark.exe - Is invalid and only throws an
Error: invalid argument
in the debug console. Also locks up the Renderer. oidnTest.exe - Is invalid and nothing happens. DiskInfo64.exe - Is invalid and nothing happens.Owing to how Chunky responded to
oidnBenchmark.exe
andError: invalid argument
I would recommend that we actually validate if the provided executable is the right one. RunningoidnDenoise.exe
oroidnDenoise.exe -h
would show a list of valid command-line options.While the exact contents of the return may change we could still check and validate some of these results.