search

chunky-dev / chunky

A path tracer to create realistic images of your Minecraft worlds.
https://chunky-dev.github.io/docs
GNU General Public License v3.0
653 stars 77 forks source link

Disabling `Draw sun` disables sunlight in the latest snapshot #1317

Closed Peregrine05 closed 2 years ago

Peregrine05 commented 2 years ago

In the latest snapshot, disabling Draw sun when SSS is set to Fast, High quality, or Off causes the sunlight to be completely disabled. This should not occur, as Draw sun is only to change the visibility of the texture of the sun on the sky. There is already a setting to disable sunlight, which is SSS: NON_LUMINOUS.

jackjt8 commented 2 years ago

To add to why this is useful-

Previously we could disable the sun texture but still have sunlight which was useful in cases where the sun texture did not fit the skymap. While this was primarily used to to actually make the sun within a SDR skymap actually provide illumination, it could also be used to further argument HDRi skymaps.