search

chunky-dev / chunky

A path tracer to create realistic images of your Minecraft worlds.
https://chunky-dev.github.io/docs
GNU General Public License v3.0
643 stars 76 forks source link

Opening the `Advanced` tab attempts to refresh the scene #1594

Closed Peregrine05 closed 1 year ago

Peregrine05 commented 1 year ago

If the Advanced tab is opened for the first time after starting Chunky, it will attempt to refresh the scene, which may be problematic if a render is already in progress.

I notice thie behavior in the snapshot release; I am not sure if it affects stable as well.

ThatRedox commented 1 year ago

This affects both snapshot and stable for different reasons. In snapshot, it appears to be a soft refresh from the octree implementation control. In stable, it appears to be a refresh from setting preventNormalEmitterWithSampling (and possibly others).

ThatRedox commented 1 year ago

For stable, it looks like #1237 needs to be backported.

leMaik commented 1 year ago

Is this issue fixed in both versions by merging both PRs?

Peregrine05 commented 1 year ago

This issue is fixed on both master and 2.4.x.