Closed JustinTimeCuber closed 1 year ago
Great, this would have helped a lot back when i did all the 1.14-1.15 stuff. Could you add a link to this PR, ie. the drawings, to the javadoc?
Great, this would have helped a lot back when i did all the 1.14-1.15 stuff. Could you add a link to this PR, ie. the drawings, to the javadoc?
Good idea, done. Also added a similar comment in QuadModel since it is relevant.
Regarding the top/bottom change: The y coordinate of textures is mirrored everywhere in Chunky (ie. 0 is at the bottom of a texture). Does this explain the confusion or is the vector actually flipped?
I think the connection there is that since the texture starts from the bottom left, that's why the first vector is the bottom left coordinate. And then the second vector is parallel to the "u-axis" and the third is parallel to the "v-axis" if that makes sense.
When I was working on the Decorated Pot model (#1602), I noticed that the Javadocs for the Quad constructors seem wrong, since as far as I can tell, the first three arguments are the bottom left, bottom right, and top left coordinates of the quad, respectively. Hopefully this helps explain - these are
Quad
s defined inQuadModel
:I confirmed that the other sides work the same way although I don't think more pictures are needed.
While I'm pretty sure something is wrong with the Javadocs, it is also possible that I'm wrong in which case I'd like to know how I am misunderstanding this.