chunky-dev / chunky

A path tracer to create realistic images of your Minecraft worlds.
https://chunky-dev.github.io/docs
GNU General Public License v3.0
643 stars 76 forks source link

Add a GUI for layered fog #1618

Closed Peregrine05 closed 11 months ago

Peregrine05 commented 1 year ago

Closes #1479. Instead of creating a more complicated GUI as shown in the issue, I decided to create a simpler one.

New: image image

megamasterbloc commented 1 year ago

maybe change layer breath to a more meaningful term like layer dispersion or layer spreading

Peregrine05 commented 1 year ago

It is called breadth internally, and it is an accurate term in my opinion.

Peregrine05 commented 12 months ago

Should I change the name of the Layer breadth control, or leave it as it is?

jackjt8 commented 12 months ago

Should I change the name of the Layer breadth control, or leave it as it is?

The definition of Breadth is "the the distance from one side to another". I haven't looked at the code as to exactly what it's used for but I'm pretty sure Breadth controls the vertical spread of the fog layer. Which.. technically would mean the wrong term is use?

Peregrine05 commented 12 months ago

I wonder if Vertical spread would be a suitable replacement.

leMaik commented 12 months ago

How about layer height?

Peregrine05 commented 12 months ago

How about layer height?

That would be too easily confused with Layer altitude, I believe.

Peregrine05 commented 12 months ago

I changed it to Layer thickness, which should be easily understandable.

leMaik commented 11 months ago

@Peregrine05 Somehow, picking the fog color of any layer changes the color of all layers.

Peregrine05 commented 11 months ago

@Peregrine05 Somehow, picking the fog color of any layer changes the color of all layers.

@leMaik This is actually a limitation of the layered fog, and is mentioned in #1428.

leMaik commented 11 months ago

Indeed, it wasn't clear how to blend the layers iirc. Can we make it obvious in the UI that the color affects all layers? Or is it obvious and I'm just blind?

Peregrine05 commented 11 months ago

It does not seem obvious to me. Another hint could be useful.

megamasterbloc commented 11 months ago

while it's a limitation of chunky I think that it's perfectly reasonable to only have one color for all fog layers. layered fog is only meant to change the distribution of fog and not it's properties

Peregrine05 commented 11 months ago

I have added a new note / hint to the fog GUI.