search

chunky-dev / chunky

A path tracer to create realistic images of your Minecraft worlds.
https://chunky-dev.github.io/docs
GNU General Public License v3.0
637 stars 76 forks source link

Homogenize Depth #1672

Closed ConsueTerra closed 7 months ago

ConsueTerra commented 8 months ago

Chunky would rely Ray.set(Ray) to increase the depth, however different routines calls this a different amount of times leading to different ray depths in a scene. Here I have removed that change and made ray depth increase explicitly to successive frames in PathTracer.pathTrace. Currently this does not explicitly change the output, but it could be a easy mistake in the future or if the ray depth is needed in other parts of the code.

leMaik commented 7 months ago

Yeah, stuff like this makes understanding the path tracing in Chunky even harder. Thanks for changing it. :+1: