search

chunky-dev / chunky

A path tracer to create realistic images of your Minecraft worlds.
https://chunky-dev.github.io/docs
GNU General Public License v3.0
637 stars 76 forks source link

Fix for possible crash in SceneChooserController.java #1677

Closed jyoo980 closed 7 months ago

jyoo980 commented 7 months ago

An unchecked call on the Optional result of Alert#showAndWait() may throw an exception at run time.

This commit refactors it to one of the recommended approaches to safely get its value here.

jyoo980 commented 7 months ago

Will push a fix for the build failure!

jyoo980 commented 7 months ago

@leMaik I have fixed the build error.

leMaik commented 7 months ago

Thank you. Not sure if an error would ever occur with this particular dialog, but it is certainly the proper way to handle this.