Avoid possibility of crash for `GeneralTab.java` and `PluginManagerController.java`

chunky-dev / chunky

A path tracer to create realistic images of your Minecraft worlds.

https://chunky-dev.github.io/docs

GNU General Public License v3.0

637 stars 76 forks source link

Avoid possibility of crash for `GeneralTab.java` and `PluginManagerController.java` #1678

Closed jyoo980 closed 6 months ago

jyoo980 commented 7 months ago

Follows from #1677

Small rewrite to safely access Optional and avoid crashes when they are empty.

jyoo980 commented 6 months ago

Hi, @leMaik

Is there anything else I can do with this PR to help get it merged? It's basically the work I already did in #1677. Thanks so much!

leMaik commented 6 months ago

@jyoo980 Thanks, looks good to me.

jyoo980 commented 6 months ago

Fantastic, thanks so much!

On Jan 28, 2024, at 12:16 PM, Maik Marschner @.***> wrote:

Reply to this email directly, view it on GitHub https://github.com/chunky-dev/chunky/pull/1678#event-11620823490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZ3EED7BJ3NSNBKMXJGD5DYQ2W2RAVCNFSM6AAAAABBBWN3G2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGYZDAOBSGM2DSMA.