[Launcher] Fix jumbled download status column after updating libraries

chunky-dev / chunky

A path tracer to create realistic images of your Minecraft worlds.

https://chunky-dev.github.io/docs

GNU General Public License v3.0

633 stars 76 forks source link

[Launcher] Fix jumbled download status column after updating libraries #1710

Closed ShirleyNekoDev closed 3 months ago

ShirleyNekoDev commented 3 months ago

chunky-launcher-version-update

Fixes jumbled status cell entries after downloading missing dependencies / updates. Bug was caused by incorrect use of JavaFX (common mistake, I did the same multiple times).

Also made the launcher launchable as a Gradle task (application plugin) and cached the status icons, instead of loading them on every status change.

Peregrine05 commented 3 months ago

Does the version need to be bumped?

leMaik commented 3 months ago

Nice! A patch bump would be nice (usually i do the bumps but i guess it's fine in this case, the other change was support for sha256 checksums iirc),

I'll merge it once ci is fixed, either by reverting the gradle changes or (preferably) fixing the issue.